Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better errors #3813

Merged
merged 13 commits into from
Apr 25, 2023
Merged

Better errors #3813

merged 13 commits into from
Apr 25, 2023

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Apr 22, 2023 •
edited
Loading

This PR tries to simplify the error implementation in Wasmer, by moving the frames into wasmer_types and the RuntimeError directly to the wasmer api (instead of the compiler/engine)

@syrusakbary
Copy link
Member Author

All tests passed, and I tested them locally as well. Merging this as is mostly cleaning up stuff and not doing any significant change, and we require it for JSC

@syrusakbary syrusakbary merged commit d9d479e into master Apr 25, 2023
@syrusakbary syrusakbary deleted the better-errors branch April 25, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@syrusakbary